Skip to content

Remove last_ update_time from ClusterCondition #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2025
Merged

Remove last_ update_time from ClusterCondition #1054

merged 6 commits into from
Jun 16, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 12, 2025 •
edited by sbernauer
Loading

Description

fixes #1032

Zookeeper status:

status:
  conditions:
  - lastTransitionTime: "2025-06-12T10:58:13Z"
    message: All StatefulSet have the requested amount of ready replicas.
    status: "True"
    type: Available
  - message: The cluster is reconciled normally.
    status: "False"
    type: ReconciliationPaused
  - message: The cluster is running.
    status: "False"
    type: Stopped
  discoveryHash: "5807873964697571649"

Release Note

The `lastUpdatedTime` was removed from the `ClusterStatus` of each operator. Users previously relying on that value should migrate to `lastTransitionTime`.

@maltesander maltesander requested a review from a team June 12, 2025 11:05
@maltesander maltesander self-assigned this Jun 12, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Jun 12, 2025
Techassi
Techassi requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we note down why this got removed in the PR description. We should also link to any other related issues/PRs.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 12, 2025
@maltesander maltesander requested a review from Techassi June 13, 2025 11:41
@sbernauer sbernauer added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jun 16, 2025
@maltesander maltesander added this pull request to the merge queue Jun 16, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Jun 16, 2025
Merged via the queue into main with commit c0c928f Jun 16, 2025
8 checks passed
@maltesander maltesander deleted the fix/remove-last-update-time branch June 16, 2025 11:28
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@Techassi Techassi Techassi approved these changes

Assignees

@maltesander maltesander

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Status: Acceptance: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClusterCondition::last_update_time is updated on no-ops, causing infinite reconciles (in the worst case)
3 participants
@maltesander @Techassi @sbernauer